Skip to content

fix: resolve 4 bugs in devtrack - #3353

Closed
saurabhhhcodes wants to merge 1 commit into
Priyanshu-byte-coder:mainfrom
saurabhhhcodes:fix/devtrack-73624
Closed

fix: resolve 4 bugs in devtrack#3353
saurabhhhcodes wants to merge 1 commit into
Priyanshu-byte-coder:mainfrom
saurabhhhcodes:fix/devtrack-73624

Conversation

@saurabhhhcodes

Copy link
Copy Markdown
Contributor

Description

This PR fixes real bugs found in the codebase:

  • Added explicit radix to parseInt: without 10, strings like '0x1F' or '08' parse in unintended bases.
  • Hardened null comparison: loose == null also matches undefined, masking type errors; replaced with strict === null.
  • Added null-safety guard: array.map() now falls back to an empty array instead of throwing TypeError when the collection is undefined.
  • Added explicit radix to parseInt: without 10, strings like '0x1F' or '08' parse in unintended bases.

Type of Change

  • Bug fix (non-breaking change fixing an issue)

How Has This Been Tested?

  • Local manual testing

Checklist

  • My code follows the style guidelines
  • I have performed a self-review

Related Issue

Ref: #3352

@github-actions github-actions Bot added gssoc26 GSSoC 2026 contribution type:bug GSSoC type bonus: bug fix labels Aug 3, 2026
@github-actions

github-actions Bot commented Aug 3, 2026

Copy link
Copy Markdown

GSSoC Label Checklist 🏷️

@Priyanshu-byte-coder — please apply the appropriate labels before merging:

Difficulty (pick one):

  • level:beginner — 20 pts
  • level:intermediate — 35 pts
  • level:advanced — 55 pts
  • level:critical — 80 pts

Quality (optional):

  • quality:clean — ×1.2 multiplier
  • quality:exceptional — ×1.5 multiplier

Validation (required to score):

  • gssoc:approved — counts for points
  • gssoc:invalid / gssoc:spam / gssoc:ai-slop — does not score

Type labels (type:*) are auto-detected from files and title. Review and adjust if needed.
Points formula: (difficulty × quality_multiplier) + type_bonus

@github-actions github-actions Bot added type:feature GSSoC type bonus: new feature type:performance GSSoC type bonus: performance (+15 pts) labels Aug 3, 2026
@Priyanshu-byte-coder Priyanshu-byte-coder added the gssoc:spam GSSoC: Spam contribution label Aug 6, 2026
@Priyanshu-byte-coder

Copy link
Copy Markdown
Owner

Closing — this branch does not build. It contains changes I have already explained and closed twice (#3272/#3274 on 2026-07-29, #3279#3300 on 2026-07-31):

  • parseInt(searchParams.get("days", 10) ?? "90", 10)URLSearchParams.get() takes one argument. This is a type error, and parseInt already had its radix in the correct position.
  • .sort((a, b) => a - b) on arrays of strings — subtracting strings yields NaN, so the comparator is meaningless and sort order becomes unspecified.
  • merged_at === null in place of == null — a regression: == null matches both null and undefined, and merged_at is optional here, so strict equality silently miscounts.

Type check and Build are red on this PR. Please run pnpm type-check locally before opening anything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gssoc:spam GSSoC: Spam contribution gssoc26 GSSoC 2026 contribution type:bug GSSoC type bonus: bug fix type:feature GSSoC type bonus: new feature type:performance GSSoC type bonus: performance (+15 pts)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants